-
Notifications
You must be signed in to change notification settings - Fork 1k
Update pre-build recipe #965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tested on Linux, Mac and Windows with space in Arduino IDE folder path, Sketch path and build output path. Tested also with VSCode. PIO is not impacted as the prebuild is not executed. |
I recommend to put the script in |
Thansk @JAndrassy |
Refering to https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5-3rd-party-Hardware-specification: Global Predefined propertiesThe Arduino IDE sets the following properties that can be used globally in all configurations files:
and: Moreover the IDE automatically provides the following properties:
So I wonder if this will change anything as so updating to: - extras.path={runtime.platform.path}/extras
+ extras.path={build.system.path}/extras will not change the behavior. |
{runtime.platform.path}, points to the folder of selected board's boards.txt file. In case of a referring definition it is not the right folder to access sdk and tools. {build.system.path} is right for this. a core can be referred by other core or by a custom hardware definition. EDIT 2020-03-05: I added BluePill to my_boards |
OK. I don't think about this use case. |
Create prebuild.sh script to perform all required actions. Same script for all supported host OS. Fixes stm32duino#957 when path contains space. Signed-off-by: Frederic Pillon <[email protected]>
See arduino-cli code (used by current I've also updated https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5-3rd-party-Hardware-specification to clarify how this works. |
Create prebuild.sh script to perform all required actions.
Same script for all supported host OS.
Fixes #957 when path contains space.
Edit: should also fixes #359